]> git.baikalelectronics.ru Git - kernel.git/commit
ACPI: property: Fix error handling in acpi_init_properties()
authorSakari Ailus <sakari.ailus@linux.intel.com>
Mon, 8 Aug 2022 21:12:13 +0000 (00:12 +0300)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 9 Aug 2022 17:14:11 +0000 (19:14 +0200)
commit0a3034f610d0414b869c9f04a4ee9944fd416b59
tree46f5b5bec7f946ca3f48848e7b10b2ca05eb823b
parentfcf5a585e98dfb38d74751a492dc3bfbc3a2e63e
ACPI: property: Fix error handling in acpi_init_properties()

buf.pointer, memory for storing _DSD data and nodes, was released if either
parsing properties or, as recently added, attaching data node tags failed.
Alas, properties were still left pointing to this memory if parsing
properties were successful but attaching data node tags failed.

Fix this by separating error handling for the two, and leaving properties
intact if data nodes cannot be tagged for a reason or another.

Reported-by: kernel test robot <oliver.sang@intel.com>
Fixes: 125b13a440a9 ("ACPI: property: Tie data nodes to acpi handles")
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
[ rjw: Drop unrelated white space change ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/property.c