]> git.baikalelectronics.ru Git - kernel.git/commit
platform/x86: dell-laptop: Fix backlight detection
authorDamien Thébault <damien@dtbo.net>
Wed, 18 Jul 2018 10:06:01 +0000 (12:06 +0200)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 20 Jul 2018 12:29:59 +0000 (15:29 +0300)
commit0a06b123b3dd23e60520dbc46819ffd5b52c536d
tree5c59f0ba2b6b325145b2a1b9594ff9c5f94de316
parentd6e702e274a4c72bc715da48a972b8ed2a6e57a5
platform/x86: dell-laptop: Fix backlight detection

Fix return code check for "max brightness" ACPI call.

The Dell laptop ACPI video brightness control is not present on dell
laptops anymore, but was present in older kernel versions.

The code that checks the return value is incorrect since the SMM
refactoring.

The old code was:
  if (buffer->output[0] == 0)

Which was changed to:
  ret = dell_send_request(...)
  if (ret)

However, dell_send_request() will return 0 if buffer->output[0] == 0,
so we must change the check to:
  if (ret == 0)

This issue was found on a Dell M4800 laptop, and the fix tested on it
as well.

Fixes: 9affb643aeba ("dell-smbios: Introduce dispatcher for SMM calls")
Signed-off-by: Damien Thébault <damien@dtbo.net>
Tested-by: Damien Thébault <damien@dtbo.net>
Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
Reviewed-by: Mario Limonciello <mario.limonciello@dell.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/platform/x86/dell-laptop.c