]> git.baikalelectronics.ru Git - kernel.git/commit
drivers/block/null_blk/main: Fix a double free in null_init.
authorLv Yunlong <lyl2019@mail.ustc.edu.cn>
Mon, 26 Apr 2021 14:32:29 +0000 (07:32 -0700)
committerJens Axboe <axboe@kernel.dk>
Mon, 26 Apr 2021 15:04:40 +0000 (09:04 -0600)
commit09a690e65724503e1516ff834031c59beca083a5
tree214bf085f0c2c07cad16da59b229145f0051f30e
parent7616ee5069718602deeb6f771583d91ebd01a173
drivers/block/null_blk/main: Fix a double free in null_init.

In null_init, null_add_dev(dev) is called.
In null_add_dev, it calls null_free_zoned_dev(dev) to free dev->zones
via kvfree(dev->zones) in out_cleanup_zone branch and returns err.
Then null_init accept the err code and then calls null_free_dev(dev).

But in null_free_dev(dev), dev->zones is freed again by
null_free_zoned_dev().

My patch set dev->zones to NULL in null_free_zoned_dev() after
kvfree(dev->zones) is called, to avoid the double free.

Fixes: e80f5c8318e2e ("nullb: factor disk parameters")
Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
Link: https://lore.kernel.org/r/20210426143229.7374-1-lyl2019@mail.ustc.edu.cn
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/null_blk/zoned.c