]> git.baikalelectronics.ru Git - kernel.git/commit
scripts/coccinelle/misc/bugon.cocci: update bug_on conversion warning
authorFabian Frederick <fabf@skynet.be>
Tue, 14 Apr 2015 22:42:34 +0000 (15:42 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 14 Apr 2015 23:48:56 +0000 (16:48 -0700)
commit090bf674df466f9f4669b00ca8d96ca058c0bd34
treebbf0b68bd35ca89f54c42dd50efc41d893f4ef5f
parentfb0e13b0173510a1f486a13cb8cc03a37383afc2
scripts/coccinelle/misc/bugon.cocci: update bug_on conversion warning

if()/BUG conversion to BUG_ON must be avoided when there's side effect
in condition.  The reason being BUG_ON won't execute the condition when
CONFIG_BUG is not defined.

With inspiration from Bruce Fields.

Signed-off-by: Fabian Frederick <fabf@skynet.be>
Suggested-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: J. Bruce Fields <bfields@fieldses.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
scripts/coccinelle/misc/bugon.cocci