]> git.baikalelectronics.ru Git - kernel.git/commit
vfs: allow file truncations when both suid and write permissions set
authorAmerigo Wang <amwang@redhat.com>
Fri, 21 Aug 2009 02:29:03 +0000 (19:29 -0700)
committerJames Morris <jmorris@namei.org>
Fri, 21 Aug 2009 04:25:48 +0000 (14:25 +1000)
commit08d8d9f0c1d495520459c61f5b5ba005319dd307
treee782e64e6e3e545a4b7c8ab108b2fcf8d01aa952
parentf16c9c8f153f85f3ee11addeb1b326bd6fb4d3a9
vfs: allow file truncations when both suid and write permissions set

When suid is set and the non-owner user has write permission, any writing
into this file should be allowed and suid should be removed after that.

However, current kernel only allows writing without truncations, when we
do truncations on that file, we get EPERM.  This is a bug.

Steps to reproduce this bug:

% ls -l rootdir/file1
-rwsrwsrwx 1 root root 3 Jun 25 15:42 rootdir/file1
% echo h > rootdir/file1
zsh: operation not permitted: rootdir/file1
% ls -l rootdir/file1
-rwsrwsrwx 1 root root 3 Jun 25 15:42 rootdir/file1
% echo h >> rootdir/file1
% ls -l rootdir/file1
-rwxrwxrwx 1 root root 5 Jun 25 16:34 rootdir/file1

Signed-off-by: WANG Cong <amwang@redhat.com>
Cc: Eric Sandeen <esandeen@redhat.com>
Acked-by: Eric Paris <eparis@redhat.com>
Cc: Eugene Teo <eteo@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Stephen Smalley <sds@tycho.nsa.gov>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: James Morris <jmorris@namei.org>
fs/open.c