]> git.baikalelectronics.ru Git - kernel.git/commit
btrfs: add RCU locks around block group initialization
authorMadhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Fri, 6 Mar 2020 06:52:43 +0000 (12:22 +0530)
committerDavid Sterba <dsterba@suse.com>
Mon, 23 Mar 2020 16:01:53 +0000 (17:01 +0100)
commit089c69720ce2be18831b6c5b5f391ce3f07d14d9
treee89c7362de88a359eeea927549e1ba32083bd944
parenta39ad19e9df80c3482fabfd9a0c8edbbf1308ddb
btrfs: add RCU locks around block group initialization

The space_info list is normally RCU protected and should be traversed
with rcu_read_lock held. There's a warning

  [29.104756] WARNING: suspicious RCU usage
  [29.105046] 5.6.0-rc4-next-20200305 #1 Not tainted
  [29.105231] -----------------------------
  [29.105401] fs/btrfs/block-group.c:2011 RCU-list traversed in non-reader section!!

pointing out that the locking is missing in btrfs_read_block_groups.
However this is not necessary as the list traversal happens at mount
time when there's no other thread potentially accessing the list.

To fix the warning and for consistency let's add the RCU lock/unlock,
the code won't be affected much as it's doing some lightweight
operations.

Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/block-group.c