]> git.baikalelectronics.ru Git - kernel.git/commit
bpf, sockmap: Fix potential memory leak on unlikely error case
authorJohn Fastabend <john.fastabend@gmail.com>
Mon, 12 Jul 2021 19:55:45 +0000 (12:55 -0700)
committerDaniel Borkmann <daniel@iogearbox.net>
Thu, 15 Jul 2021 17:49:12 +0000 (19:49 +0200)
commit0726d263a474200f95d8844c44a4f0b7bfc9b6b4
tree410c90ca2c317060d065ba411c7fd8821256ec23
parent7e481920b5d6439cbd447e0526c27fd870ac396a
bpf, sockmap: Fix potential memory leak on unlikely error case

If skb_linearize is needed and fails we could leak a msg on the error
handling. To fix ensure we kfree the msg block before returning error.
Found during code review.

Fixes: f446892e940b4 ("bpf, sockmap: Avoid failures from skb_to_sgvec when skb has frag_list")
Signed-off-by: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Cong Wang <cong.wang@bytedance.com>
Link: https://lore.kernel.org/bpf/20210712195546.423990-2-john.fastabend@gmail.com
net/core/skmsg.c