]> git.baikalelectronics.ru Git - kernel.git/commit
USB: serial: ch341: fix disabled rx timer on older devices
authorJohan Hovold <johan@kernel.org>
Tue, 6 Sep 2022 13:34:35 +0000 (15:34 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 15 Sep 2022 10:04:53 +0000 (12:04 +0200)
commit06b78ba74f466a5fe88e2a2a5490d6580f4dbe5b
treebbe6121d960e2adee0a28dcef328dbac24edec9a
parent2dd4db4fc9834e4acf6e30f9ecfedc5a5c28dba8
USB: serial: ch341: fix disabled rx timer on older devices

commit f8f55ffc7629916ec43b93b9c7059eca12d9f259 upstream.

At least one older CH341 appears to have the RX timer enable bit
inverted so that setting it disables the RX timer and prevents the FIFO
from emptying until it is full.

Only set the RX timer enable bit for devices with version newer than
0x27 (even though this probably affects all pre-0x30 devices).

Reported-by: Jonathan Woithe <jwoithe@just42.net>
Tested-by: Jonathan Woithe <jwoithe@just42.net>
Link: https://lore.kernel.org/r/Ys1iPTfiZRWj2gXs@marvin.atrad.com.au
Fixes: ddd74a622bf0 ("USB: serial: ch341: reinitialize chip on reconfiguration")
Cc: stable@vger.kernel.org # 4.10
Signed-off-by: Johan Hovold <johan@kernel.org>
[ johan: backport to 5.4 ]
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/serial/ch341.c