]> git.baikalelectronics.ru Git - kernel.git/commit
serial: amba-pl011: do not time out prematurely when draining tx fifo
authorLino Sanfilippo <LinoSanfilippo@gmx.de>
Fri, 8 Apr 2022 23:35:02 +0000 (01:35 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 15 Apr 2022 09:41:56 +0000 (11:41 +0200)
commit0641f883b6c58c48edafdcab4ca8161570fbb477
tree652aa8ae8bcc8ebf42f5892f8ac4dbbfd7e66816
parent2edbc52220245b81df8431b57f28537dd5ce3a0c
serial: amba-pl011: do not time out prematurely when draining tx fifo

The current timeout for draining the tx fifo in RS485 mode is calculated by
multiplying the time it takes to transmit one character (with the given
baud rate) with the maximal number of characters in the tx queue.

This timeout is too short for two reasons:
First when calculating the time to transmit one character integer division
is used which may round down the result in case of a remainder of the
division.

Fix this by rounding up the division result.

Second the hardware may need additional time (e.g for first putting the
characters from the fifo into the shift register) before the characters are
actually put onto the wire.

To be on the safe side double the current maximum number of iterations
that are used to wait for the queue draining.

Fixes: 07b7f9ea3724 ("serial: amba-pl011: add RS485 support")
Cc: stable@vger.kernel.org
Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Link: https://lore.kernel.org/r/20220408233503.7251-1-LinoSanfilippo@gmx.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/amba-pl011.c