]> git.baikalelectronics.ru Git - kernel.git/commit
media: cedrus: Fix H264 decoding
authorJernej Skrabec <jernej.skrabec@siol.net>
Wed, 23 Dec 2020 11:06:59 +0000 (12:06 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 26 Jan 2021 18:15:32 +0000 (19:15 +0100)
commit063bef6adf109e08c4ce776b4e78347212a885ea
tree646d01cd46561fc9df425858414a7a376ffe9162
parent2e714543d6db62b12e1aa5021f0ed13ac0b743b9
media: cedrus: Fix H264 decoding

During H264 API overhaul subtle bug was introduced Cedrus driver.
Progressive references have both, top and bottom reference flags set.
Cedrus reference list expects only bottom reference flag and only when
interlaced frames are decoded. However, due to a bug in Cedrus check,
exclusivity is not tested and that flag is set also for progressive
references. That causes "jumpy" background with many videos.

Fix that by checking that only bottom reference flag is set in control
and nothing else.

Tested-by: Andre Heider <a.heider@gmail.com>
Fixes: 5380d18d0cca ("media: cedrus: h264: Properly configure reference field")
Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: <stable@vger.kernel.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/sunxi/cedrus/cedrus_h264.c