]> git.baikalelectronics.ru Git - kernel.git/commit
ARM: OMAP1: ams-delta: Fix impossible .irq < 0
authorJanusz Krzysztofik <jmkrzyszt@gmail.com>
Tue, 2 Oct 2018 09:45:29 +0000 (11:45 +0200)
committerTony Lindgren <tony@atomide.com>
Thu, 4 Oct 2018 14:29:41 +0000 (07:29 -0700)
commit05b2f9bfdbdb079e8b0711fcb83a00943f93ae1f
treee3ca862d6082694046bddf5e1d29cd4c9609cea2
parent8bf079ff6c143d4d1fef56e14e3b465dadd67ba0
ARM: OMAP1: ams-delta: Fix impossible .irq < 0

Since the very beginning, unsigned int .irq member of struct
plat_serial8250_port introduced by commit d740d41f605c ("OMAP1:
AMS_DELTA: add modem support") was statically initialized to a negative
value -EINVAL.  Moreover, commit 33bcff213aac ("ARM: OMAP1: ams-delta:
assign MODEM IRQ from GPIO descriptor") has introduced some new code
which checks for that member carrying a negative value which is
impossible.

Use IRQ_NOTCONNECTED instead of -EINVAL. Also, drop the valueless check
and let the modem device be registered regardless of .irq value, and
the value handled by "serial8250" driver.

Fixes: 33bcff213aac ("ARM: OMAP1: ams-delta: assign MODEM IRQ from GPIO descriptor")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>
Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Tony Lindgren <tony@atomide.com>
arch/arm/mach-omap1/board-ams-delta.c