]> git.baikalelectronics.ru Git - kernel.git/commit
qlcnic: Remove redundant unlock in qlcnic_pinit_from_rom
authorDinghao Liu <dinghao.liu@zju.edu.cn>
Fri, 3 Sep 2021 07:35:43 +0000 (15:35 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 4 Sep 2021 09:50:59 +0000 (10:50 +0100)
commit057df67378bf1b8e571e55bd93d934563d7471b0
tree799313cbaa20572937bf240773d6c10697b6f2ca
parent84ed48170662cd9bf3bfa0b4e23d35691d52323c
qlcnic: Remove redundant unlock in qlcnic_pinit_from_rom

Previous commit b8408e57ea17 removes the qlcnic_rom_lock()
in qlcnic_pinit_from_rom(), but remains its corresponding
unlock function, which is odd. I'm not very sure whether the
lock is missing, or the unlock is redundant. This bug is
suggested by a static analysis tool, please advise.

Fixes: b8408e57ea17 ("qlcnic: updated reset sequence")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c