]> git.baikalelectronics.ru Git - kernel.git/commit
IB/mlx4: Don't use GFP_ATOMIC for CQ resize struct
authorRoland Dreier <roland@purestorage.com>
Fri, 29 Jul 2016 04:58:43 +0000 (21:58 -0700)
committerDoug Ledford <dledford@redhat.com>
Thu, 4 Aug 2016 01:03:32 +0000 (21:03 -0400)
commit0557bc808d29df97a9816d03ecc126d468c909db
tree11bb391f7fa6cd441e939a2ca4bf8754bb631824
parentca3c5d1749da83dd8b6e55f3590e365f30ac054f
IB/mlx4: Don't use GFP_ATOMIC for CQ resize struct

We allocate a small tracking structure as part of mlx4_ib_resize_cq().
However, we don't need to use GFP_ATOMIC -- immediately after the
allocation, we call mlx4_cq_resize(), which allocates a command
mailbox with GFP_KERNEL and then sleeps on a firmware command, so we
better not be in an atomic context.

This actually has a real impact, because when this GFP_ATOMIC
allocation fails (and GFP_ATOMIC does fail in practice) then a
userspace consumer resizing a CQ will get a spurious failure that we
can easily avoid.

Signed-off-by: Roland Dreier <roland@purestorage.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/hw/mlx4/cq.c