]> git.baikalelectronics.ru Git - kernel.git/commit
HID: elan: Fix potential double free in elan_input_configured
authorMiaoqian Lin <linmq006@gmail.com>
Sat, 16 Apr 2022 07:37:21 +0000 (07:37 +0000)
committerJiri Kosina <jkosina@suse.cz>
Thu, 21 Apr 2022 09:38:28 +0000 (11:38 +0200)
commit053105e525a1def364fd700d934d36a50b36057e
tree614364f9b462e9ddb7607521108e15b71e74481b
parent8d360c8b2a5432a20172d5eed2b7b2220be68c8a
HID: elan: Fix potential double free in elan_input_configured

'input' is a managed resource allocated with devm_input_allocate_device(),
so there is no need to call input_free_device() explicitly or
there will be a double free.

According to the doc of devm_input_allocate_device():
 * Managed input devices do not need to be explicitly unregistered or
 * freed as it will be done automatically when owner device unbinds from
 * its driver (or binding fails).

Fixes: 1abffac4cdfa ("HID: elan: Fix memleak in elan_input_configured")
Fixes: 572360939234 ("HID: Add driver for USB ELAN Touchpad")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-elan.c