]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: be2iscsi: Fix a theoretical leak in beiscsi_create_eqs()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 28 Sep 2020 09:13:00 +0000 (12:13 +0300)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 3 Oct 2020 01:32:36 +0000 (21:32 -0400)
commit04f08654e5dfa1b84ac4b036e0c8eadd01b17393
tree6b0322120d3d6eb0b73d9e9d665433126a020b61
parentf9400b5d1ac9e2a3449e80e947f37c35dd4478ff
scsi: be2iscsi: Fix a theoretical leak in beiscsi_create_eqs()

The be_fill_queue() function can only fail when "eq_vaddress" is NULL and
since it's non-NULL here that means the function call can't fail.  But
imagine if it could, then in that situation we would want to store the
"paddr" so that dma memory can be released.

Link: https://lore.kernel.org/r/20200928091300.GD377727@mwanda
Fixes: 38ef72878ce3 ("[SCSI] be2iscsi: Adding msix and mcc_rings V3")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/be2iscsi/be_main.c