]> git.baikalelectronics.ru Git - kernel.git/commit
KVM: s390: sthyi: fix sthyi inline assembly
authorHeiko Carstens <heiko.carstens@de.ibm.com>
Thu, 3 Aug 2017 11:05:11 +0000 (13:05 +0200)
committerChristian Borntraeger <borntraeger@de.ibm.com>
Mon, 21 Aug 2017 13:34:36 +0000 (15:34 +0200)
commit03dde7f6a246a214c8fd95fa1cfdf3e55143312a
treebd3d10884a4e173722dfad4099f4e20adb66c68e
parent40437a0fa4b6d14c5403f1e3d5c02121134de433
KVM: s390: sthyi: fix sthyi inline assembly

The sthyi inline assembly misses register r3 within the clobber
list. The sthyi instruction will always write a return code to
register "R2+1", which in this case would be r3. Due to that we may
have register corruption and see host crashes or data corruption
depending on how gcc decided to allocate and use registers during
compile time.

Fixes: fb78104de5b6 ("KVM: s390: Add sthyi emulation")
Cc: <stable@vger.kernel.org> # 4.8+
Reviewed-by: Janosch Frank <frankja@linux.vnet.ibm.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
arch/s390/kvm/sthyi.c