]> git.baikalelectronics.ru Git - kernel.git/commit
net: usb: asix: Fix less than zero comparison of a u16
authorColin Ian King <colin.king@canonical.com>
Wed, 9 Jun 2021 10:24:47 +0000 (11:24 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 9 Jun 2021 21:54:03 +0000 (14:54 -0700)
commit03c0e535b11bb69ea13dc8eadde5d00e339ca1fd
tree6b740d0dcaf492ae8178591c9cacaf636e748f7b
parent8849341a3693eacdb6a1f6610de9a66164c253c2
net: usb: asix: Fix less than zero comparison of a u16

The comparison of the u16 priv->phy_addr < 0 is always false because
phy_addr is unsigned. Fix this by assigning the return from the call
to function asix_read_phy_addr to int ret and using this for the
less than zero error check comparison.

Addresses-Coverity: ("Unsigned compared against 0")
Fixes: 3ce7841abdc9 ("net: usb: asix: ax88772: add phylib support")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/asix_devices.c