]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915/gem: Pin the L-shape quirked object as unshrinkable
authorChris Wilson <chris@chris-wilson.co.uk>
Mon, 17 May 2021 08:46:40 +0000 (09:46 +0100)
committerMatthew Auld <matthew.auld@intel.com>
Mon, 17 May 2021 13:12:52 +0000 (14:12 +0100)
commit0385af822fa36a501df6c2d3547ab41bc7540622
tree443ee504f6d56d3b35135eacb53a0f30810dc58c
parent9c8411eb95616645d6bba7b6eed3a41d72ab0a69
drm/i915/gem: Pin the L-shape quirked object as unshrinkable

When instantiating a tiled object on an L-shaped memory machine, we mark
the object as unshrinkable to prevent the shrinker from trying to swap
out the pages. We have to do this as we do not know the swizzling on the
individual pages, and so the data will be scrambled across swap out/in.

Not only do we need to move the object off the shrinker list, we need to
mark the object with shrink_pin so that the counter is consistent across
calls to madvise.

v2: in the madvise ioctl we need to check if the object is currently
shrinkable/purgeable, not if the object type supports shrinking

Fixes: 98f3c9386b79 ("drm/i915/gem: Use shrinkable status for unknown swizzle quirks")
References: https://gitlab.freedesktop.org/drm/intel/-/issues/3293
References: https://gitlab.freedesktop.org/drm/intel/-/issues/3450
Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Tested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: <stable@vger.kernel.org> # v5.12+
Link: https://patchwork.freedesktop.org/patch/msgid/20210517084640.18862-1-matthew.auld@intel.com
drivers/gpu/drm/i915/gem/i915_gem_pages.c
drivers/gpu/drm/i915/i915_gem.c