]> git.baikalelectronics.ru Git - kernel.git/commit
arm64: dts: exynos: fix polarity of "enable" line of NFC chip in TM2
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 29 Sep 2022 01:15:55 +0000 (18:15 -0700)
committerKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Fri, 30 Sep 2022 12:23:33 +0000 (14:23 +0200)
commit03768e1a192f2216d8e570609079fcd0f6845134
tree13b37787cf435f2c276e3a981c193a136ebdb657
parent3d7dcb2c5450a57f60c448f42be48fdfe456bfdf
arm64: dts: exynos: fix polarity of "enable" line of NFC chip in TM2

According to s3fwrn5 driver code the "enable" GPIO line is driven "high"
when chip is not in use (mode is S3FWRN5_MODE_COLD), and is driven "low"
when chip is in use.

s3fwrn5_phy_power_ctrl():

...
gpio_set_value(phy->gpio_en, 1);
...
if (mode != S3FWRN5_MODE_COLD) {
msleep(S3FWRN5_EN_WAIT_TIME);
gpio_set_value(phy->gpio_en, 0);
msleep(S3FWRN5_EN_WAIT_TIME);
}

Therefore the line described by "en-gpios" property should be annotated
as "active low".

The wakeup gpio appears to have correct polarity (active high).

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Link: https://lore.kernel.org/r/20220929011557.4165216-1-dmitry.torokhov@gmail.com
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi