]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915/hsw: Flush RING_IMR changes before changing the global GT IMR (vecs)
authorChris Wilson <chris@chris-wilson.co.uk>
Sat, 5 Jan 2019 11:56:47 +0000 (11:56 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Mon, 7 Jan 2019 11:32:29 +0000 (11:32 +0000)
commit035b5304f7be9af402ff131e99d0f7e31a5114f1
tree5fba639274df099bbfe16567c65535f5389d8aab
parent1b0850b1bc6aada676644a0360b4499dc0ff4bfc
drm/i915/hsw: Flush RING_IMR changes before changing the global GT IMR (vecs)

Haswell also requires the RING_IMR flush for its unique vebox setup to
avoid losing interrupts, as per acdba8ae5e01 ("drm/i915/gen6: Flush
RING_IMR changes before changing the global GT IMR"):

On Baytail, notably, we can still detect missed interrupt syndrome
(where we never spot a completed request). In this case, it can be
alleviated by always keeping the interrupt unmasked, implying that the
interrupt is being lost in the window after modifying the IMR. (This is
the reason we still have the posting reads on enable_irq, if we remove
them we miss interrupts!) Having narrowed the issue down to the IMR,
rather than keeping it always enabled, applying the usual posting
read/flush of the RING_IMR before unmasking the GT IMR also seems to
prevent the missed interrupt. So be it.

References: acdba8ae5e01 ("drm/i915/gen6: Flush RING_IMR changes before changing the global GT IMR")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190105115647.4970-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/intel_ringbuffer.c