]> git.baikalelectronics.ru Git - kernel.git/commit
powerpc/prom_init: Use -ffreestanding to avoid a reference to bcmp
authorNathan Chancellor <natechancellor@gmail.com>
Tue, 19 Nov 2019 04:57:12 +0000 (21:57 -0700)
committerMichael Ellerman <mpe@ellerman.id.au>
Mon, 25 Nov 2019 10:45:43 +0000 (21:45 +1100)
commit033e0c137b9c0a90f1006664ddf993029f470025
tree1d349e0f10260c21fc4dc5700216913e913dbd61
parent19b14de76260f107517821cd65633065e5aeaa27
powerpc/prom_init: Use -ffreestanding to avoid a reference to bcmp

LLVM revision r374662 gives LLVM the ability to convert certain loops
into a reference to bcmp as an optimization; this breaks
prom_init_check.sh:

    CALL    arch/powerpc/kernel/prom_init_check.sh
  Error: External symbol 'bcmp' referenced from prom_init.c
  make[2]: *** [arch/powerpc/kernel/Makefile:196: prom_init_check] Error 1

bcmp is defined in lib/string.c as a wrapper for memcmp so this could
be added to the whitelist. However, commit
4b61cb374dc0 ("powerpc/prom_init: don't use string functions from
lib/") copied memcmp as prom_memcmp to avoid KASAN instrumentation so
having bcmp be resolved to regular memcmp would break that assumption.
Furthermore, because the compiler is the one that inserted bcmp, we
cannot provide something like prom_bcmp.

To prevent LLVM from being clever with optimizations like this, use
-ffreestanding to tell LLVM we are not hosted so it is not free to
make transformations like this.

Reviewed-by: Nick Desaulneris <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20191119045712.39633-4-natechancellor@gmail.com
arch/powerpc/kernel/Makefile