]> git.baikalelectronics.ru Git - kernel.git/commit
zram: fix return value on writeback_store
authorMinchan Kim <minchan@kernel.org>
Sat, 13 Mar 2021 05:08:38 +0000 (21:08 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sat, 13 Mar 2021 19:27:31 +0000 (11:27 -0800)
commit0323dc1d9dc46344cb18383144b6c26443f41561
treed194df9e1bd248a7e4c143a9c3071dd77c924492
parent5ac47d2bdf70581c8be019293528b4c7682fe646
zram: fix return value on writeback_store

writeback_store's return value is overwritten by submit_bio_wait's return
value.  Thus, writeback_store will return zero since there was no IO
error.  In the end, write syscall from userspace will see the zero as
return value, which could make the process stall to keep trying the write
until it will succeed.

Link: https://lkml.kernel.org/r/20210312173949.2197662-1-minchan@kernel.org
Fixes: 26a3a1b15d01("drivers/block/zram/zram_drv.c: fix error return codes not being returned in writeback_store")
Signed-off-by: Minchan Kim <minchan@kernel.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Colin Ian King <colin.king@canonical.com>
Cc: John Dias <joaodias@google.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/block/zram/zram_drv.c