]> git.baikalelectronics.ru Git - kernel.git/commit
[SCSI] fix crash when disconnecting usb storage
authorAlexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Tue, 17 Nov 2009 22:10:11 +0000 (14:10 -0800)
committerJames Bottomley <James.Bottomley@suse.de>
Thu, 26 Nov 2009 16:04:22 +0000 (10:04 -0600)
commit020ee9ded5b096d49a5bb420e981133afb795f37
tree7e55e191d74412735f8e9cd96e50dd50f34b9a5e
parentab7477cb2ba283bace50ca5919c2253af39653a9
[SCSI] fix crash when disconnecting usb storage

__scsi_remove_device() in scsi_forget_host() is executed out of scan_mutex
and races with scsi_destroy_sdev() <- scsi_sysfs_add_devices() <-
scsi_finish_async_scan().  The result is use after free and/or double
free, oops.

The fix is simple, move scsi_forget_host() under scan_mutex.

scsi_forget_host() is just sequence of __scsi_remove_device().  All
another calls of __scsi_remove_device() are made under scan_mutex.  So
that it is safe.

Signed-off-by: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Signed-off-by: Denis V. Lunev <den@openvz.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/scsi/hosts.c