]> git.baikalelectronics.ru Git - kernel.git/commit
HID: Revert "Revert "HID: Fix logitech-dj: missing Unifying device issue""
authorNestor Lopez Casado <nlopezcasad@logitech.com>
Thu, 18 Jul 2013 13:21:30 +0000 (06:21 -0700)
committerJiri Kosina <jkosina@suse.cz>
Mon, 22 Jul 2013 14:32:24 +0000 (16:32 +0200)
commit017601882b12ca3331de5987a9e54c2bbbef5add
tree6c77869acd520b9a7688ac8ee7e883924662c669
parenteed2aecedc84578dbedb4cfe27b743162d1cc186
HID: Revert "Revert "HID: Fix logitech-dj: missing Unifying device issue""

This reverts commit dc99cedc36970816fc04678b8882948a94fd203a.

This patch re-adds the workaround introduced by 206d8435fbad6be
which was reverted by dc99cedc36970816f.

The original patch 596264 was needed to overcome a situation where
the hid-core would drop incoming reports while probe() was being
executed.

This issue was solved by 5680d97dd2ee48455 which added
hid_device_io_start() and hid_device_io_stop() that enable a specific
hid driver to opt-in for input reports while its probe() is being
executed.

Commit c6e93f9e9f327732 modified hid-logitech-dj so as to use the
functionality added to hid-core. Having done that, workaround 596264
was no longer necessary and was reverted by dc99ced.

We now encounter a different problem that ends up 'again' thwarting
the Unifying receiver enumeration. The problem is time and usb controller
dependent. Ocasionally the reports sent to the usb receiver to start
the paired devices enumeration fail with -EPIPE and the receiver never
gets to enumerate the paired devices.

With 67a9a03e7691bfad05 the problem was "hidden" as the call to the usb
driver became asynchronous and none was catching the error from the
failing URB.

As the root cause for this failing SET_REPORT is not understood yet,
-possibly a race on the usb controller drivers or a problem with the
Unifying receiver- reintroducing this workaround solves the problem.

Overall what this workaround does is: If an input report from an
unknown device is received, then a (re)enumeration is performed.

related bug:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1194649

Signed-off-by: Nestor Lopez Casado <nlopezcasad@logitech.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-logitech-dj.c
drivers/hid/hid-logitech-dj.h