]> git.baikalelectronics.ru Git - kernel.git/commit
perf report: Don't shadow inlined symbol with different addr range
authorHe Kuang <hekuang@huawei.com>
Tue, 19 Feb 2019 13:05:31 +0000 (21:05 +0800)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 19 Feb 2019 15:30:12 +0000 (12:30 -0300)
commit0135693fd99a403ca1569a3a068ced9f82f62b9f
tree7657521e13771c3897f764a562c41d8e529a3fce
parentae2d9cb3621e62d5381c640704fab428719b1772
perf report: Don't shadow inlined symbol with different addr range

We can't assume inlined symbols with the same name are equal, because
their address range may be different. This will cause the symbols with
different addresses be shadowed when adding to the hist entry, and lead
to ERANGE error when checking the symbol address during sample parse,
the addr should be within the range of [sym.start, sym.end].

The error message is like: "0x36aea60 [0x8]: failed to process type: 68".

The second parameter of symbol__new() is the length of the fake symbol
for the inline frame, which is the subtraction of the end and start
address of base_sym.

Signed-off-by: He Kuang <hekuang@huawei.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Milian Wolff <milian.wolff@kdab.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Fixes: d9877d17765d ("perf report: Compare symbol name for inlined frames when sorting")
Link: http://lkml.kernel.org/r/20190219130531.15692-1-hekuang@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/sort.c
tools/perf/util/srcline.c