]> git.baikalelectronics.ru Git - kernel.git/commit
projects / kernel.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: fcf8c11) | patch
tty: n_gsm: improper skb_pull() use was leaking framed data
authorRuss Gorby <russ.gorby@intel.com>
Tue, 14 Jun 2011 20:23:29 +0000 (13:23 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 16 Jun 2011 19:00:15 +0000 (12:00 -0700)
commit012d5e694a4b45c386587bdf5bda0a9da6b71d45
treeec5cc4b87ae3e3abc2749ec5010ba668231a017etree | snapshot
parentfcf8c11d53bbc32f0fd57cc7db63227d36bfa496commit | diff
tty: n_gsm: improper skb_pull() use was leaking framed data

gsm_dlci_data_output_framed() was doing:
memcpy(dp, skb_pull(dlci->skb, len), len);

The problem is skb_pull() returns the post-increment data ptr
so the first chunk of dlci->skb->data is leaked.

Signed-off-by: Russ Gorby <russ.gorby@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/tty/n_gsm.c diff | blob | history
Linux Kernel Source Tree.