]> git.baikalelectronics.ru Git - kernel.git/commit
libceph: don't pass request to calc_layout()
authorAlex Elder <elder@inktank.com>
Sat, 16 Feb 2013 04:10:17 +0000 (22:10 -0600)
committerSage Weil <sage@inktank.com>
Thu, 2 May 2013 04:14:27 +0000 (21:14 -0700)
commit0114a02986f241396970070e010be6c7a53dd52b
tree8ef3612ee584c972b97e3d5e1aa632f9204b47e7
parentd013b1ab1d75956388e0f96d67d9910ba49fa864
libceph: don't pass request to calc_layout()

The only remaining reason to pass the osd request to calc_layout()
is to fill in its r_num_pages and r_page_alignment fields.  Once it
fills those in, it doesn't do anything more with them.

We can therefore move those assignments into the caller, and get rid
of the "req" parameter entirely.

Note, however, that the only caller is ceph_osdc_new_request(),
and that immediately overwrites those fields with values based on
its passed-in page offset.  So the assignment inside calc_layout()
was redundant anyway.

This resolves:
    http://tracker.ceph.com/issues/4262

Signed-off-by: Alex Elder <elder@inktank.com>
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
net/ceph/osd_client.c