]> git.baikalelectronics.ru Git - kernel.git/commit
lib/mpi: mpi_read_raw_from_sgl(): fix nbits calculation
authorNicolai Stange <nicstange@gmail.com>
Tue, 22 Mar 2016 12:17:27 +0000 (13:17 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Tue, 5 Apr 2016 12:35:51 +0000 (20:35 +0800)
commit00b3bbc1f4145b753a84bfa50b2271f4ce4d1fe1
tree848eb86e6d3968c0896ba6fd865b89c3441eb4ec
parent47fb3f16d69f0ee12fc9d1bff1a50a284e344451
lib/mpi: mpi_read_raw_from_sgl(): fix nbits calculation

The number of bits, nbits, is calculated in mpi_read_raw_from_sgl() as
follows:

  nbits = nbytes * 8;

Afterwards, the number of leading zero bits of the first byte get
subtracted:

  nbits -= count_leading_zeros(*(u8 *)(sg_virt(sgl) + lzeros));

However, count_leading_zeros() takes an unsigned long and thus,
the u8 gets promoted to an unsigned long.

Thus, the above doesn't subtract the number of leading zeros in the most
significant nonzero input byte from nbits, but the number of leading
zeros of the most significant nonzero input byte promoted to unsigned long,
i.e. BITS_PER_LONG - 8 too many.

Fix this by subtracting

  count_leading_zeros(...) - (BITS_PER_LONG - 8)

from nbits only.

Fixes: ebd84f3efad6 ("lib/mpi: Add mpi sgl helpers")
Signed-off-by: Nicolai Stange <nicstange@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
lib/mpi/mpicoder.c