]> git.baikalelectronics.ru Git - kernel.git/commit
lockd: lockd server-side shouldn't set fl_ops
authorJ. Bruce Fields <bfields@redhat.com>
Fri, 20 Aug 2021 21:01:59 +0000 (17:01 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Sep 2021 10:26:34 +0000 (12:26 +0200)
commit009bc3dcb23ae24b874571a1922f822da0250c07
tree03bb323b65da4ef316d9e033b157e6bd32cf299a
parent0562608250795a4aa2d166c046b50e57908fd8ad
lockd: lockd server-side shouldn't set fl_ops

[ Upstream commit 7de875b231edb807387a81cde288aa9e1015ef9e ]

Locks have two sets of op arrays, fl_lmops for the lock manager (lockd
or nfsd), fl_ops for the filesystem.  The server-side lockd code has
been setting its own fl_ops, which leads to confusion (and crashes) in
the reexport case, where the filesystem expects to be the only one
setting fl_ops.

And there's no reason for it that I can see-the lm_get/put_owner ops do
the same job.

Reported-by: Daire Byrne <daire@dneg.com>
Tested-by: Daire Byrne <daire@dneg.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/lockd/svclock.c