]> git.baikalelectronics.ru Git - kernel.git/commit
net: switchdev: do not propagate bridge updates across bridges
authorRussell King <rmk+kernel@armlinux.org.uk>
Wed, 26 Feb 2020 17:14:21 +0000 (17:14 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 27 Oct 2021 07:54:24 +0000 (09:54 +0200)
commit0063f23cfed8b34063e5f75aad37fb3b859bd8e1
tree4d21c5fa5f7b9d980945b624346709f54386fa6a
parenta31dbcc0308475c9d78f450a1ea172548cce1c66
net: switchdev: do not propagate bridge updates across bridges

commit 1312c9672ab58afcbaf914bd2a558c77e8d0d1b4 upstream.

When configuring a tree of independent bridges, propagating changes
from the upper bridge across a bridge master to the lower bridge
ports brings surprises.

For example, a lower bridge may have vlan filtering enabled.  It
may have a vlan interface attached to the bridge master, which may
then be incorporated into another bridge.  As soon as the lower
bridge vlan interface is attached to the upper bridge, the lower
bridge has vlan filtering disabled.

This occurs because switchdev recursively applies its changes to
all lower devices no matter what.

Reviewed-by: Ido Schimmel <idosch@mellanox.com>
Tested-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Cc: Fabian Bläse <fabian@blaese.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/switchdev/switchdev.c